Allow existing GenomicsDb as input to incrementally update#1116
Draft
FriederikeHanssen wants to merge 2 commits intonf-core:devfrom
Draft
Allow existing GenomicsDb as input to incrementally update#1116FriederikeHanssen wants to merge 2 commits intonf-core:devfrom
FriederikeHanssen wants to merge 2 commits intonf-core:devfrom
Conversation
|
maxulysse
reviewed
Jun 19, 2023
| "cnvkit_reference": { | ||
| "type": "string", | ||
| "default": null, | ||
| "default": "None", |
Member
There was a problem hiding this comment.
Suggested change
| "default": "None", | |
| "default": null, |
Member
There was a problem hiding this comment.
which tools version were you using for that to happen?
Contributor
Author
There was a problem hiding this comment.
2.8. I think, used gitpod, so should be latest release I think
Member
There was a problem hiding this comment.
@mirpedrol was this issue fixed or not with 2.8: nf-core/tools#1841
Member
There was a problem hiding this comment.
Is there a reason why you need to define it as null in the schema, the best would be to not set any default value, but still initialize it to null in the nextflow.config
Member
There was a problem hiding this comment.
Should that be part of schema linting?
Just removing default None/null,"" values.
That way, no need to deal with null-> None issues at all
Member
There was a problem hiding this comment.
Adding it to linting sounds good :)
maxulysse
reviewed
Jun 19, 2023
| "type": "string", | ||
| "fa_icon": "fa-solid fa-text", | ||
| "default": null, | ||
| "default": "None", |
Member
There was a problem hiding this comment.
Suggested change
| "default": "None", | |
| "default": null, |
4 tasks
maxulysse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).