Backport odometry to foxy-devel and other ROS2 related fixes#132
Merged
Achllle merged 36 commits intonasa-jpl:foxy-develfrom May 20, 2021
Merged
Backport odometry to foxy-devel and other ROS2 related fixes#132Achllle merged 36 commits intonasa-jpl:foxy-develfrom
Achllle merged 36 commits intonasa-jpl:foxy-develfrom
Conversation
… idle. Now also sending a full stop command after a little bit so that we can minimize idle power consumption
…for running on your system. Will default to the original file if that's not found
…nch script now, so it's robust to updates; allow user to make a custom osr_mod.launch file now (example usage: when you don't have the led screen); make the launch script name lowercase
Make rover full stop the wheels when idle
Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
Robustify launch script
add missing underscore in service instructions [backport]
Collaborator
|
Unclear, do you want me to test and approve? |
Collaborator
Author
|
I tested myself but extra testing is always welcome. I built a good-looking map using this so it's already better than nothing 👍 |
apollokit
requested changes
May 5, 2021
Collaborator
|
Note that I tested the code briefly and works fine. |
Collaborator
Author
|
Backported #135 and #136. @apollokit ready for re-review |
apollokit
reviewed
May 11, 2021
Achllle
changed the title
apollokit
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #118 but for ROS2
See also #63