Skip to content

Implement wheel odometry#118

Merged
Achllle merged 17 commits intonasa-jpl:masterfrom
Achllle:iss63
Apr 23, 2021
Merged

Implement wheel odometry#118
Achllle merged 17 commits intonasa-jpl:masterfrom
Achllle:iss63

Conversation

@Achllle
Copy link
Collaborator

@Achllle Achllle commented Oct 12, 2020

Description

Wheel odometry is a commonly used form of odometry useful for e.g. localization and mapping.

Default behavior is to not calculate it. It can be enabled using an argument;

roslaunch osr_bringup osr.launch enable_odometry:=true

To Do

  • needs rigorous testing with all the changes from master recently
  • implement proper covariance estimate

@Achllle Achllle self-assigned this Oct 12, 2020
@Achllle Achllle added the enhancement New feature or request label Oct 12, 2020
@Achllle
Copy link
Collaborator Author

Achllle commented Nov 15, 2020

Ignore some changes that git is showing that are already in master, it has trouble with squashed commits and rebases.

Let me know if something is missing or needs explanation!

@Achllle
Copy link
Collaborator Author

Achllle commented Feb 14, 2021

@apollokit @ericjunkins bump

Copy link
Collaborator

@apollokit apollokit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and it runs fine on my rover with ROS1.

Couple things:

  • are you going to put in a proper covariance estimate?
  • would be nice to have a little bit of an explanation of the odometry message somewhere in the docs (a .md file in this repo is fine). I would just briefly explain the output of rostopic echo odom, as seen in the screencap below

Screenshot from 2021-04-06 18-48-18

@Achllle
Copy link
Collaborator Author

Achllle commented Apr 12, 2021

Added a reference link and covariance. Since odometry is not enabled by default and is a more advanced option, I don't think we should explain it in the repo. Instead I added a link to my blog.

@Achllle
Copy link
Collaborator Author

Achllle commented Apr 20, 2021

@apollokit

@apollokit
Copy link
Collaborator

Added a reference link and covariance. Since odometry is not enabled by default and is a more advanced option, I don't think we should explain it in the repo. Instead I added a link to my blog.

Can you at least mention here what the units are on pose and twist? Or give a link where someone can find out? I understand it's a more advanced option, but seems like its helpfulness is limited without at least some context...

@Achllle
Copy link
Collaborator Author

Achllle commented Apr 21, 2021

This is the standard ROS odometry message, which is described in the link that I added (did you see the link?). For those who are going to set up a nav stack, they will need odometry at one point, which is what this is for. Someone who doesn't want to build a nav stack shouldn't care about launching odometry in the first place.

@apollokit
Copy link
Collaborator

This is the standard ROS odometry message, which is described in the link that I added (did you see the link?). For those who are going to set up a nav stack, they will need odometry at one point, which is what this is for. Someone who doesn't want to build a nav stack shouldn't care about launching odometry in the first place.

a'ight

@Achllle Achllle merged commit 8e25540 into nasa-jpl:master Apr 23, 2021
@Achllle Achllle deleted the iss63 branch April 23, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants