This repository was archived by the owner on Aug 24, 2021. It is now read-only.
feat: updates multihash table #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds script to auto update - reduces bundle size by having only one explicit table - remove defaultLengths seems to not be used and multicoded tables doesn't have it BREAKING CHANGE: defaultLengths removed
|
also breaks by changing case of some of the names, like but very good change though! I wondered why this was manually replicated and I guess that's just historical. |
jacobheun
reviewed
Apr 8, 2020
|
@hugomrdias could you please force-push this commit again with an updated commit message that also makes the "Skein" casing change as breaking change (this way it should show up nicely in the changelog). It could be done while merging, but i also forgot doing those things quite often :) |
|
@jacobheun FYI changed the maintainer to me |
|
This contains a breaking change, it should have gone out as
Please can you re-release |
achingbrain
added a commit
to ipld/js-ipld-git
that referenced
this pull request
Jun 19, 2020
Since multiformats/js-multihash#76 was released the `multihashes` module does not export default hash lengths any more. Sadly it went out as a patch release which means `ipld-git` is broken. This PR hard codes the hash length as it is known, and also removes the `multihashes` dep as we can use the one exported from `multihashing-async`. Ref: multiformats/js-multihash#76 (comment)
achingbrain
added a commit
to ipld/js-ipld-git
that referenced
this pull request
Jun 19, 2020
Since multiformats/js-multihash#76 was released the `multihashes` module does not export default hash lengths any more. For reasons that are unclear it went out as a patch release which means `ipld-git` is currently broken. This PR hard codes the hash length as it is known, and also removes the `multihashes` dep as we can use the one exported from `multihashing-async` and updates other deps. Ref: multiformats/js-multihash#76 (comment)
vmx
pushed a commit
to ipld/js-ipld-git
that referenced
this pull request
Jun 19, 2020
Since multiformats/js-multihash#76 was released the `multihashes` module does not export default hash lengths any more. For reasons that are unclear it went out as a patch release which means `ipld-git` is currently broken. This PR hard codes the hash length as it is known, and also removes the `multihashes` dep as we can use the one exported from `multihashing-async` and updates other deps. Ref: multiformats/js-multihash#76 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #73
BREAKING CHANGE: defaultLengths removed, skein is now lowercase