This repository was archived by the owner on Aug 24, 2021. It is now read-only.
fix: multihashes does not export default lengths any more #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since multiformats/js-multihash#76 was released the `multihashes` module does not export default hash lengths any more. For reasons that are unclear it went out as a patch release which means `ipld-git` is currently broken. This PR hard codes the hash length as it is known, and also removes the `multihashes` dep as we can use the one exported from `multihashing-async` and updates other deps. Ref: multiformats/js-multihash#76 (comment)
achingbrain
force-pushed
the
fix/multihashes-breaking-change
branch
from
c5f3aaa to
caf6eb0
Compare
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 84.55% 84.49% -0.06%
==========================================
Files 7 7
Lines 259 258 -1
==========================================
- Hits 219 218 -1
Misses 40 40
Continue to review full report at Codecov.
|
|
Thanks a lot @achingbrain. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since multiformats/js-multihash#76 was released the
multihashesmodule does not export default hash lengths any more.For reasons that are not clear it went out as a patch release which means
ipld-gitis currently broken.This PR hard codes the hash length as it is known, and also removes the
multihashesdep as we can use the one exported frommultihashing-async.Ref: multiformats/js-multihash#76 (comment)