[scheduler] Add missing ARIA attributes to side panel toggle and resources legend#22012
Open
mixelburg wants to merge 1 commit intomui:masterfrom
Open
[scheduler] Add missing ARIA attributes to side panel toggle and resources legend#22012mixelburg wants to merge 1 commit intomui:masterfrom
mixelburg wants to merge 1 commit intomui:masterfrom
Conversation
…a-hidden to collapsed panel, and aria-labelledby to resources legend
|
Deploy preview: https://deploy-preview-22012--material-ui-x.netlify.app/ Bundle size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21982
Closes #21983
Closes #21984
Summary
Three accessibility improvements to the EventCalendar scheduler:
Side panel toggle button (HeaderToolbar) — issue #21982:
aria-expanded={isSidePanelOpen}so screen readers can report whether the panel is open or closedaria-controls="event-calendar-side-panel"linking the button to the panel it controls, matching the pattern already used byPreferencesMenuSide panel when collapsed — issue #21983:
id="event-calendar-side-panel"toEventCalendarSidePanel(thearia-controlstarget)aria-hidden={!isSidePanelOpen}so collapsed panel content is hidden from the accessibility treeResources legend section — issue #21984:
aria-label(which differed from the visible label) witharia-labelledbypointing to the visible "Resources" labelidtoResourcesLegendLabelso both sighted and screen reader users get the same label text