Changed "remove" to "delete", "update" to "edit" in lexicons #15155
Conversation
Ruslan-Aleev
changed the title
|
This made me wonder: what's the difference between "remove" and "delete"?
|
|
In MODX, with the exception of Resources, everything is permanently deleted, it seems to me. Therefore, the term "Delete" is more applicable (although it is better to use it for resources too, so that there is no confusion). |
core/lexicon/en/default.inc.php
Outdated
| $_lang['empty_recycle_bin'] = 'Delete Deleted Resources'; | ||
| $_lang['empty_recycle_bin_confirm'] = 'Are you sure you want to completely and permanently delete all deleted Resources? This is irreversible.'; | ||
| $_lang['empty_recycle_bin_empty'] = 'There are no deleted Resources to delete.'; | ||
| $_lang['empty_recycle_bin_emptied'] = 'All deleted Resources have been permanently deleted.'; |
There was a problem hiding this comment.
English isn't my first language but I would use "Erase" instead of "Delete" when talking about deleting/removing Deleted Resources.
A native English speaker's view on this would be great!
JoshuaLuckers
added
the
pr/ready-for-merging
…#15155] Merge remote-tracking branch 'upstream/pr/15155' into 3.x * upstream/pr/15155: Changed "new" to "create" in lexicons Changed "update" to "edit" in lexicons Changed "remove" to "delete" in lexicons
Merge remote-tracking branch 'upstream/pr/15447' into 3.x
rthrash
removed
the
pr/ready-for-merging
What does it do?
Changed "remove" to "delete", "update" to "edit" in lexicons. PR only changes lexicons entries.
p.s. In the future, it is necessary to simplify the lexicons entries (key: value) and create a standard for writing them.
Often there are duplicates:
https://github.com/modxcms/revolution/blob/3.x/core/lexicon/en/snippet.inc.php#L20
https://github.com/modxcms/revolution/blob/3.x/core/lexicon/en/snippet.inc.php#L28
Why is it needed?
For unification in the interface.
Related issue(s)/PR(s)
#13554