Skip to content

Aiming to Fix Conformer OOM #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Aiming to Fix Conformer OOM #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad8f72b
Initial Commit
pomonam Mar 19, 2024
de238bc
Lint fix
pomonam Mar 19, 2024
f208dd2
Lint fix
pomonam Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions algorithmic_efficiency/workloads/librispeech_conformer/librispeech_pytorch/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def __init__(self,
out_features=self.encoder_dim,
bias=True)
self.pos_encode = AddPositionalEmbedding(embedding_dim=self.encoder_dim)
self.dropout = nn.Dropout(p=self.input_dropout_rate)
self.dropout = nn.Dropout(p=self.input_dropout_rate, inplace=True)

def forward(self, inputs, input_paddings):
output_paddings = input_paddings
Expand Down Expand Up @@ -195,7 +195,7 @@ def __init__(self, config: ConformerConfig):
in_features=config.encoder_dim,
out_features=config.encoder_dim * config.feed_forward_expansion_factor,
bias=True)
self.dropout1 = nn.Dropout(p=config.feed_forward_dropout_rate)
self.dropout1 = nn.Dropout(p=config.feed_forward_dropout_rate, inplace=True)
self.linear2 = nn.Linear(
in_features=config.encoder_dim * config.feed_forward_expansion_factor,
out_features=config.encoder_dim,
Expand All @@ -206,8 +206,9 @@ def __init__(self, config: ConformerConfig):
else:
feed_forward_residual_dropout_rate = (
config.feed_forward_residual_dropout_rate)
self.dropout2 = nn.Dropout(p=feed_forward_residual_dropout_rate)

self.dropout2 = nn.Dropout(
p=feed_forward_residual_dropout_rate, inplace=True)

def forward(self, inputs, padding_mask):
inputs = self.ln(inputs)
inputs = self.linear1(inputs)
Expand Down Expand Up @@ -316,7 +317,7 @@ def __init__(self, config: ConformerConfig):
attention_residual_dropout_rate = 0.1
else:
attention_residual_dropout_rate = config.attention_residual_dropout_rate
self.dropout = nn.Dropout(p=attention_residual_dropout_rate)
self.dropout = nn.Dropout(p=attention_residual_dropout_rate, inplace=True)

def forward(self, outputs, paddings):
outputs = self.ln(outputs)
Expand Down Expand Up @@ -407,7 +408,7 @@ def __init__(self, config):
conv_residual_dropout_rate = 0.0
else:
conv_residual_dropout_rate = config.conv_residual_dropout_rate
self.dropout = nn.Dropout(p=conv_residual_dropout_rate)
self.dropout = nn.Dropout(p=conv_residual_dropout_rate, inplace=True)

def forward(self, inputs, input_paddings):
inputs = self.ln(inputs)
Expand Down
1 change: 1 addition & 0 deletions submission_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ def train_once(
log_dir: Optional[str] = None,
save_checkpoints: Optional[bool] = True
) -> Tuple[spec.Timing, Dict[str, Any]]:
_reset_cuda_mem()
data_rng, opt_init_rng, model_init_rng, rng = prng.split(rng, 4)

# Workload setup.
Expand Down