Skip to content

Aiming to Fix Conformer OOM #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2024
Merged

Aiming to Fix Conformer OOM #710

merged 3 commits into from
Mar 29, 2024

Conversation

pomonam
Copy link
Contributor

@pomonam pomonam commented Mar 19, 2024

Tries to address #663.

  • Resets the memory at the beginning of training.
  • Change dropout to have inplace=True

@pomonam pomonam requested a review from a team as a code owner March 19, 2024 17:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg
Copy link
Contributor

Hey Juhan, can you address the lint errors so we can merge this in?

@priyakasimbeg priyakasimbeg merged commit 26c2e57 into dev Mar 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
@pomonam pomonam deleted the conformer_dropout branch April 6, 2024 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pomonam @priyakasimbeg