Skip to content

Set visibility of markdown cells before rendering it #126099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Set visibility of markdown cells before rendering it #126099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
}
}

async function createMarkdownPreview(cellId: string, content: string, top: number): Promise<HTMLElement> {
async function createMarkdownPreview(cellId: string, content: string, top: number, visible: boolean): Promise<HTMLElement> {
const container = document.getElementById('container')!;
const cellContainer = document.createElement('div');

Expand All @@ -1084,6 +1084,7 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
cellContainer.id = cellId;
cellContainer.classList.add('preview');

cellContainer.style.visibility = visible ? 'visible' : 'hidden';
cellContainer.style.position = 'absolute';
cellContainer.style.top = top + 'px';
container.appendChild(cellContainer);
Expand Down Expand Up @@ -1157,12 +1158,11 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
await Promise.all(update.map(async cell => {
let container = document.getElementById(cell.cellId);
if (container) {
container.style.visibility = cell.visible ? 'visible' : 'hidden';
await updateMarkdownPreview(container, cell.cellId, cell.content);
} else {
container = await createMarkdownPreview(cell.cellId, cell.content, cell.offset);
container = await createMarkdownPreview(cell.cellId, cell.content, cell.offset, cell.visible);
}

container.style.visibility = cell.visible ? 'visible' : 'hidden';
}));
}

Expand Down