Skip to content

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jun 11, 2021

Backports fix for #126056 to 1.57

For #126056

This was regressed when we made rendering potentially be async

Before 1.57, rendering was always sync, so during initialization we would:

  1. Create markdown cell
  2. Render
  3. Set visibility of the cell (usually to hidden)

For 1.57, we made rendering async. This can cause the following to happen:

  1. Create markdown cell
  2. await Render
  3. A call to showMarkdownCell comes in and now reveal the cell
  4. Render completes and we then incorrectly hide the markdown cell

Backports fix for microsoft#126056 to 1.57

For microsoft#126056

This was regressed when we made rendering potentially be async
@mjbvz mjbvz added this to the May 2021 milestone Jun 11, 2021
@mjbvz mjbvz requested a review from connor4312 June 11, 2021 22:53
@mjbvz mjbvz self-assigned this Jun 11, 2021
@mjbvz mjbvz modified the milestones: May 2021, May 2021 Recovery Jun 11, 2021
@mjbvz mjbvz merged commit 6370d95 into microsoft:release/1.57 Jun 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants