Ensure scripts compile, are checked in strict mode #49524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
changed the title
jakebailey
commented
Jun 13, 2022
| @@ -33,6 +33,7 @@ | |||
| "@octokit/rest": "latest", | |||
| "@types/chai": "latest", | |||
| "@types/convert-source-map": "latest", | |||
| "@types/fs-extra": "^9.0.13", | |||
There was a problem hiding this comment.
Noticed this while cleaning up our dependencies, as I was hoping we could just use fs/promises instead (unfortunately not).
sandersn
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing something else, I noticed that the code in scripts doesn't compile (and also is not strict, so masked a missing dependency). Fix these.
I manually tested
buildProtocol.ts, and it seems to still be correct. I assume that it used to be that passing no script target meant the latest, but if that's not the case, I can switch it.