Ensure scripts compile, are checked in strict mode (#49524)

jakebailey · web-flow · commit 884f5ac258a2 · 2022-06-14T16:28:42.000-07:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -33,6 +33,7 @@
         "@octokit/rest": "latest",
         "@types/chai": "latest",
         "@types/convert-source-map": "latest",
+        "@types/fs-extra": "^9.0.13",
         "@types/glob": "latest",
         "@types/gulp": "^4.0.9",
         "@types/gulp-concat": "latest",
diff --git a/scripts/buildProtocol.ts b/scripts/buildProtocol.ts
@@ -159,7 +159,7 @@ function writeProtocolFile(outputFile: string, protocolTs: string, typeScriptSer
             if (fileName === protocolFileName) {
                 return ts.createSourceFile(fileName, protocolDts, options.target);
             }
-            return originalGetSourceFile.apply(host, [fileName]);
+            return originalGetSourceFile.apply(host, [fileName, ts.ScriptTarget.Latest]);
         };
         const rootFiles = includeTypeScriptServices ? [protocolFileName, typeScriptServicesDts] : [protocolFileName];
         return ts.createProgram(rootFiles, options, host);
diff --git a/scripts/tsconfig.json b/scripts/tsconfig.json
@@ -1,6 +1,6 @@
 {
     "compilerOptions": {
-        "strictNullChecks": true,
+        "strict": true,
         "removeComments": false,
         "declaration": false,
         "sourceMap": true,

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ function writeProtocolFile(outputFile: string, protocolTs: string, typeScriptSer`
`159`	`159`	`if (fileName === protocolFileName) {`
`160`	`160`	`return ts.createSourceFile(fileName, protocolDts, options.target);`
`161`	`161`	`}`
`162`		`- return originalGetSourceFile.apply(host, [fileName]);`
	`162`	`+ return originalGetSourceFile.apply(host, [fileName, ts.ScriptTarget.Latest]);`
`163`	`163`	`};`
`164`	`164`	`const rootFiles = includeTypeScriptServices ? [protocolFileName, typeScriptServicesDts] : [protocolFileName];`
`165`	`165`	`return ts.createProgram(rootFiles, options, host);`