Skip to content

update eslint, fix eslint @typescript-eslint/no-unnecessary-type-assertion errors #33804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Oct 4, 2019

Based on node types stdout and columns cannot be undefined, and eslint clearly handles that case, however, Travis CI failed to run host.ts

    interface Process extends EventEmitter {
        /**
         * Can also be a tty.WriteStream, not typed due to limitation.s
         */
        stdout: WriteStream;
 columns: number;

cc @uniqueiniquity

@a-tarasyuk a-tarasyuk force-pushed the feature/update-eslint branch from ac4452d to a3da2e7 Compare October 4, 2019 08:00
@a-tarasyuk a-tarasyuk changed the title update eslint update eslint, fix eslint @typescript-eslint/no-unnecessary-type-assertion errors Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants