Skip to content

'amd' missing from error message for error TS1323 #33803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

'amd' missing from error message for error TS1323 #33803

merged 1 commit into from
Oct 7, 2019

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Oct 4, 2019 •
edited
Loading

DanielRosenwasser
DanielRosenwasser reviewed Oct 4, 2019
View reviewed changes
@DanielRosenwasser
Copy link
Member

Looks like tests are failing because

ERROR: /home/vsts/work/1/s/src/testRunner/parallel/host.ts:150:54 @typescript-eslint/no-unnecessary-type-assertion This assertion is unnecessary since it does not change the type of the expression.
ERROR: /home/vsts/work/1/s/src/testRunner/parallel/host.ts:159:62 @typescript-eslint/no-unnecessary-type-assertion This assertion is unnecessary since it does not change the type of the expression.

@a-tarasyuk
Copy link
Contributor Author

@DanielRosenwasser

Looks like tests are failing because

Yes, my PR (#33804) which fix these errors has been merged., just need to restart tests

@DanielRosenwasser DanielRosenwasser merged commit 09a87b9 into microsoft:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"amd" missing from error message for error TS1323
2 participants
@a-tarasyuk @DanielRosenwasser