Detect and prevent creation of bad Identifier #21581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from
ghost
commented
Feb 2, 2018
| @@ -14,9 +14,3 @@ | |||
| //// function f(o) { return o.nested.[|great|]; } | |||
|
|
|||
| verify.rangesReferenceEachOther(); | |||
|
|
|||
There was a problem hiding this comment.
This was the test that broke under the new assertion. I'm just removing a comment here that does nothing (it only has two slashes).
There was a problem hiding this comment.
Yeah, I must have left it from earlier testing and checked it in by mistake. But it would probably be good to retain this as a parser test.
There was a problem hiding this comment.
By "this" I meant the above code. This below is a regular comment that doesn't test anything.
ghost
mentioned this pull request
sandersn
approved these changes
Feb 2, 2018
| @@ -14,9 +14,3 @@ | |||
| //// function f(o) { return o.nested.[|great|]; } | |||
|
|
|||
| verify.rangesReferenceEachOther(); | |||
|
|
|||
There was a problem hiding this comment.
Yeah, I must have left it from earlier testing and checked it in by mistake. But it would probably be good to retain this as a parser test.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20792
In
Node.getChildren()we create synthetic nodes for all of the tokens that weren't parsed. This can cause a problem if we scan anIdentifierbecause we don't give it any text here (and besides, an Identifier shouldn't be trivia). After adding an assertion and running all tests, I found that there was one kind of jsdoc node which we weren't avoiding scanning trivia for -- we need to avoid scanning trivia for these because arbitrary tokens could appear in a comment.