Skip to content

Assert the result of getTokenValue is defined #21339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Assert the result of getTokenValue is defined #21339

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2018

First stab at #20792. In that issue an identifier has no escapedText set -- that eventually comes from here.

@ghost ghost requested a review from rbuckton January 22, 2018 19:51
@ghost ghost mentioned this pull request Jan 22, 2018
Merged
@ghost ghost force-pushed the assertTokenValueDefined branch from 6500760 to 79a0f37 Compare January 22, 2018 19:56
mhegazy
mhegazy suggested changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add an assert in the scanner. if this fires, the whole LS will be hosed.

@ghost
Copy link
Author

ghost commented Feb 2, 2018

OK, better fix at #21581

@ghost ghost closed this Feb 2, 2018
@ghost ghost deleted the assertTokenValueDefined branch February 2, 2018 19:49
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhegazy