-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Declaration emit for es6 import syntax #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly or indirectly
…ts emit Emit those new declarations asynchronously since they are otherwise not visible
793936c
to
fc1528f
Compare
session.ts to use this field. Remove sort of nav items from getNavigateToItems in sesion.ts because LS now does the sort. Removed no content throw in quick info as this happens frequently with Sublime (every cursor move calls quick info, and quick info is only available on symbols). Added mechanism for other commands to avoid throwing and instead return a specific error message, so that we don't make the log unreadable (as it was with hundreds of quick info stack traces).
…when collecting nav bar items
…or binary operator, adjust existing SpaceBeforeOpenBraceInFunction rule to recognize blocks
Split Iterator into Iterator and IterableIterator in es6.d.ts
Allow commas as a separator between object/interface type members.
Emit downlevel parameter initializers unless we are certain they don't have any side effects.
Emit arrow functions with expression bodies 'as is' when targetting ES6 ...
Move NavigateTo over to using the new pattern matcher.
Fix failing test.
Add support for printing colors to the command line when running mocha!
Add space after '?' only for conditional operators
…ents use character instead of column when formatting multiline comments with ...
…t 1.5 has shipped.
Formatting in destructuring
do not include constructor parameters with binding patterns as names whe...
Wrap getDefaultLibFileName API changes in a try/catch until TypeScript 1...
delete unused files
Fix export * merging to not overwrite original members
Conflicts: tests/baselines/reference/es6ImportDefaultBinding.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamedImport.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamedImportInEs5.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamespaceBinding.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamespaceBindingInEs5.errors.txt tests/baselines/reference/es6ImportDefaultBindingInEs5.errors.txt
Merged
Is this outdated and should be closed with #2139? |
yup. thanks @csnover |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates the referenced import declarations into the .d.ts file.