Emit downlevel parameter initializers unless we are certain they don't have any side effects. #2109
+889
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hasPossibleSideEffects((<ParameterDeclaration>node).initializer); | ||
|
|
||
| case SyntaxKind.PropertyAccessExpression: | ||
| return hasPossibleSideEffects((<PropertyAccessExpression>node).expression); |
There was a problem hiding this comment.
This should return true due to get accessors. Leave a comment about that.
There was a problem hiding this comment.
Great catch exclamation point
|
👍 |
Conflicts: tests/baselines/reference/recursiveClassReferenceTest.js.map
CyrusNajmabadi
added a commit
that referenced
this pull request
Feb 23, 2015
Emit downlevel parameter initializers unless we are certain they don't have any side effects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. if you have:
function foo(a = "") { }Then we can emit that as:
function foo(a) { }but if you have:
function foo(a = bar()) { }then we need to emit that as:
This also unifies some of emitting code between single line function blocks and other types of functions.