Fix: make show-core-output is failing due to lack of access to management storage account#4407
Merged
jonnyry merged 5 commits intoFeb 28, 2025
Conversation
added 3 commits
February 27, 2025 21:29
…ut and improve error handling in mgmtstorage scripts.
…ake show-core-output`
Contributor
There was a problem hiding this comment.
PR Overview
This PR resolves the issue with the failing management storage access when running the make show-core-output command and cleans up redundant error messages. It also streamlines access verification in the associated shell script.
- Resolves management storage access issue for terraform show command.
- Consolidates error message handling in mgmtstorage_enable_public_access.sh.
- Removes unnecessary access checks to simplify idempotent network rule operations.
Reviewed Changes
| File | Description |
|---|---|
| CHANGELOG.md | Updated the change log with details on the bug fix and error cleanup. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 8956946. ♻️ This comment has been updated with latest results. |
added 2 commits
February 28, 2025 04:32
…lean up error messages in mgmtstorage_enable_public_access.sh script
Collaborator
Author
|
/test 8956946 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13581524730 (with refid (in response to this comment from @ashis-kar91) |
jonnyry
approved these changes
Feb 28, 2025
jonnyry
left a comment
jonnyry
left a comment
Collaborator
There was a problem hiding this comment.
Looking good, thanks very much :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4404
What is being addressed
make show-core-outputcommand in the make file was executingterraform showwas failing due to lack of access to the management storage account. Because of this TRE deployments were failing while using themake allcommand.devops/scripts/mgmtstorage_enable_public_access.shduring every attempt to verify the storage account access.How is this addressed
core/terraform/show_output.sh, which will be usingterraform_wrapper.shto execute the terraform show.terraform_wrapper.shalready has the script for management storage exception.devops/scripts/mgmtstorage_enable_public_access.sh, captured the underlying error in every attempt and printing it at the end if all the attempts fail.devops/scripts/mgmtstorage_enable_public_access.shbefore adding and removing network rules, since both the commands are idempotent.