Skip to content

[Backport] Assign with and, or, replaced by &&, || #21247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2019
Merged

[Backport] Assign with and, or, replaced by &&, || #21247

merged 2 commits into from
Feb 18, 2019

Conversation

Dharmeshvaja91
Copy link
Contributor

Original Pull Request

#20628

Description (*)

It is recommended to use the &&, || operators, instead of and, or to prevent confusion.

I kept the integrity of the source code on the occurrences with xor that returns boolean , if we use ^ instead of xor it'll return integer.

Fixed Issues (if relevant)

N/A

@magento-engcom-team
Copy link
Contributor

Hi @Dharmeshvaja91. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4278 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 18, 2019

Hi @Dharmeshvaja91, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lfluvisotto
Copy link
Contributor

@osrecio , @ihor-sviziev

It was to be me who should have created this backport because I am the original author of PR.

@ihor-sviziev
Copy link
Contributor

Hi @lfluvisotto,
You'll have 5 contribution points as you're author of original PR.
More info: https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants