Assign with and, or, replaced by &&, ||

[lfluvisotto]

Description (*)

It is recommended to use the &&, || operators, instead of and, or to prevent confusion.

I kept the integrity of the source code on the occurrences with xor that returns boolean , if we use ^ instead of xor it'll return integer.

Fixed Issues (if relevant)

N/A

[magento-engcom-team]

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[novikor]

Review results: fine.
@swnsma , please approve

[swnsma]

Hi @lfluvisotto
Thank you for your contribution!
I see at least 20 additional places of using or/add/xor instead of ||/&&/^^.

Can I ask you to check them too?

[lfluvisotto]

@swnsma

I decided to keep the integrity of the source code on the occurrences with xor (Logical Operator) that returns boolean, if we use ^ (Bitwise Operator) instead of xor it'll return integer .

I used the regular expression only (and|or) , except on comments and string literals.

The results I got were different of your screenshot, because your results are included string literals.

[ghost]

Hi @lfluvisotto, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[orlangur]

@sivaschenko @swnsma @novikor guys, please do not merge such changes without a corresponding static test.