Skip to content

Added BoxNotEmptyRule to validators #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2020
Merged

Added BoxNotEmptyRule to validators #358

merged 2 commits into from
Oct 28, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 27, 2020 •
edited by coderimus
Loading

Description

Added BoxNotEmptyRule to validators where original verbose validations were removed

Fixed Issues (if relevant)

  1. Fixes Plugin linemarkers is missing for interface methods #322: Implement module name validation in 'Create a plugin' and 'New module' dialog

Questions

How do we handle the issue raised at #318 (comment)?

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus self-assigned this Oct 27, 2020
@coderimus coderimus self-requested a review October 28, 2020 11:26
coderimus
coderimus approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drpayyne
Thank you for the investigation and implementation. A great example of the simple solution required more work during research and simple code solution. 👍

@coderimus coderimus merged commit 352c37b into magento:2.1.0-develop Oct 28, 2020
@drpayyne drpayyne mentioned this pull request Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

Labels
Easy Medium partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin linemarkers is missing for interface methods
3 participants
@drpayyne @coderimus @magento-engcom-team