Changed new module dialog validator #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpayyne
commented
Oct 20, 2020
Comment on lines
-140
to
-153
| if (moduleName.equals(packageName)) { | ||
| final String errorMessage = validatorBundle.message( | ||
| "validator.moduleNameIsTheSameAsPackage", | ||
| MODULE_NAME | ||
| ); | ||
| JOptionPane.showMessageDialog( | ||
| null, | ||
| errorMessage, | ||
| errorTitle, | ||
| JOptionPane.ERROR_MESSAGE | ||
| ); | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
This exists to check if the module name and package name are identical and throws an error if so.
- Do we need this check?
- How do we perform this through annotations? Module name field validation needs to access the package name to compare.
I'm unsure on how to proceed with this. Please advise. Thanks!
There was a problem hiding this comment.
There no system restrictions to call module e.g Vendor_Vendor.
However, this is wrong from the best practices standpoint.
@bohdan-harniuk
How do you think it can be implemented?
There was a problem hiding this comment.
I understand @VitaliyBoyko, but just to note: a few modules which I noticed that have the same vendor and module name
- elasticsearch/elasticsearch
- container-interop/container-interop
- cache/cache
- mockery/mockery
VitaliyBoyko
requested changes
Oct 22, 2020
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
VitaliyBoyko
approved these changes
Oct 22, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds validation through annotations to the new module dialog and removes the unnecessary
com.magento.idea.magento2plugin.actions.generation.dialog.validator.NewModuleDialogValidator.Fixed Issues
Questions or comments
There is one validation pending to be refactored into the annotation-type. I have addressed that below. Please advise on how to proceed on that. Thanks!
Contribution checklist