Skip to content

Fixed disabling plugin on a startup when Magento not in the root #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

Fixed disabling plugin on a startup when Magento not in the root #344

merged 1 commit into from
Oct 23, 2020

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)
Fixed issue with constant disabling on startup when Magento not in the root.

Fixed Issues (if relevant)

  1. Plugin automatically disables after PhpStorm restart #342: Plugin automatically disables after PhpStorm restart

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ihor-sviziev ihor-sviziev self-assigned this Oct 23, 2020
@ihor-sviziev
Copy link
Contributor

Oh, thx for the quick fix! Checking if that works...

@VitaliyBoyko VitaliyBoyko linked an issue Oct 23, 2020 that may be closed by this pull request
Plugin automatically disables after PhpStorm restart #342
Closed
ihor-sviziev
ihor-sviziev suggested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked - the fix works fine! 👍

Could you cover your change with automated test?

@VitaliyBoyko
Copy link
Contributor Author

Created an issue #347 for the test coverage.

@coderimus coderimus merged commit aa473de into 2.0.1-develop Oct 23, 2020
@VitaliyBoyko VitaliyBoyko deleted the 342-fixed-magento-path-suggestion branch October 23, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@coderimus coderimus coderimus approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@coderimus coderimus

Labels
Event: MageCONF CD 2020 Partner: Atwix partners-contribution Progress: approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin automatically disables after PhpStorm restart
4 participants
@VitaliyBoyko @ihor-sviziev @coderimus @magento-engcom-team