Fix compression in addFileFromStream #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maennchen could u plz merge this and tag a new release ? as atm any streaming ops will give a corrupted zip file. |
|
@ctf0 I'm testing some known edge cases (mostly with Apple's Unarchiver) right now. Will merge it right after if everything works as expected. |
|
Everything good to go! Thank you very much ❤️ |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gzdeflate() creates a single compression stream, so they can't be concatenated together, which causes the original code to fail on data > 1mb. This patch uses deflate_init (available starting from PHP 7) to properly incrementally compress data. This can be tested by compressing something with size > 1024kb, such as a file created via
fallocate -l1025K dummy.bin.