Fix CRC calculation for addFileFromStream #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the CRC calculation for data added from streams. It should be calculating the CRC over the uncompressed data, not the compressed data.
unzip -t file.zip
on linux can be used to verify the integrity of zipped data.The following short program can can be used to demonstrate the issue. Without this patch, the CRC verification fails because it calculates the CRC over the compressed data instead of the original data.