Skip to content

Conversation

sherrardb
Copy link
Collaborator

update statement_description to backwards-compatible statement_descriptor for Net::Stripe::Charge and Net::Stripe::Plan https://stripe.com/docs/upgrades#2014-12-17;
add failing test to detect previously-missing attribute in Net::Stripe::Charge;

my testing, and the documentation shows this change to be backwards-compatible:
"If not on this API version or newer, providing a statement_descriptor still triggers the statement_description behavior."

we were previously passing statement_description to Net::Stripe::Charge, but it was being dropped on the floor since there was no matching attribute.

@andrewsolomon
Copy link
Collaborator

Looks good! It just needs your comment above in the release notes so that people know they need to change their own code accordingly.

@sherrardb
Copy link
Collaborator Author

this may sound like a silly question this late in the game, but where do i find and how do i edit the release notes? i don't see anything in my local repo that fits the bill, and i have not yet transitioned to operating on the upstream repo.

of course i may just be overlooking something obvious. :-)

@andrewsolomon
Copy link
Collaborator

this may sound like a silly question this late in the game, but where do i find and how do i edit the release notes? i don't see anything in my local repo that fits the bill, and i have not yet transitioned to operating on the upstream repo.

of course i may just be overlooking something obvious. :-)

Yes, I obviously have an overly active imagination! :-) I don't know why I thought we had release notes. That said, better late than never, so I recommend that you replace the section

=head2 WARNING

with

=head1 RELEASE NOTES

=head2 Version 0.40

=item fixed API versioning

Blah, blah..

What do you think?

@sherrardb
Copy link
Collaborator Author

:-)
will do, once we have settled the issue of merge order.

@sherrardb sherrardb mentioned this pull request Dec 24, 2019
 * add failing test to detect ignored attribute `statement_descriptor` in Net::Stripe::Charge
 * add missing `statement_descriptor` attribute in Net::Stripe::Charge
 * update `statement_description` to `statement_descriptor` Net::Stripe::Plan
 * API docs <https://stripe.com/docs/upgrades#2014-12-17> indicate that this change is backwards-compatible
@sherrardb sherrardb force-pushed the update-statement-description branch from 538578f to 71c4e9f Compare January 17, 2020 02:43
@sherrardb sherrardb merged commit b765c69 into lukec:master Jan 17, 2020
@sherrardb sherrardb deleted the update-statement-description branch January 17, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants