update statement_description to backwards-compatible statement_descriptor for Net::Stripe::Charge and Net::Stripe::Plan <https://stripe.com/docs/upgrades#2014-12-17>;

add failing test to detect previously-missing attribute in Net::Stripe::Charge;

Author: sherrardb

lib/Net/Stripe.pm

@@ -114,7 +114,7 @@ L<https://stripe.com/docs/api#create_charge>
 
 =item * capture - Bool - optional
 
-=item * statement_description - Str - description for statement - optional
+=item * statement_descriptor - Str - descriptor for statement - optional
 
 =item * application_fee - Int - optional
 
@@ -194,7 +194,7 @@ Charges: {
                        Str :$description?,
                        HashRef :$metadata?,
                        Bool :$capture?,
-                       Str :$statement_description?,
+                       Str :$statement_descriptor?,
                        Int :$application_fee?,
                        Str :$receipt_email?
                      ) {
@@ -205,7 +205,7 @@ Charges: {
                                               description => $description,
                                               metadata => $metadata,
                                               capture => $capture,
-                                              statement_description => $statement_description,
+                                              statement_descriptor => $statement_descriptor,
                                               application_fee => $application_fee,
                                               receipt_email => $receipt_email
                                           );
@@ -818,7 +818,7 @@ L<https://stripe.com/docs/api#create_plan>
 
 =item * trial_period_days - Int - optional
 
-=item * statement_description - Str - optional
+=item * statement_descriptor - Str - optional
 
 =back
 
@@ -893,7 +893,7 @@ Plans: {
                      Str :$name,
                      Int :$trial_period_days?,
                      HashRef :$metadata?,
-                     Str :$statement_description?) {
+                     Str :$statement_descriptor?) {
         my $plan = Net::Stripe::Plan->new(id => $id,
                                           amount => $amount,
                                           currency => $currency,
@@ -902,7 +902,7 @@ Plans: {
                                           name => $name,
                                           trial_period_days => $trial_period_days,
                                           metadata => $metadata,
-                                          statement_description => $statement_description);
+                                          statement_descriptor => $statement_descriptor);
         return $self->_post('plans', $plan);
     }
 

lib/Net/Stripe/Charge.pm

@@ -27,14 +27,16 @@ has 'invoice'             => (is => 'ro', isa => 'Maybe[Str]');
 has 'receipt_email'       => (is => 'ro', isa => 'Maybe[Str]');
 has 'status'              => (is => 'ro', isa => 'Maybe[Str]');
 has 'capture'             => (is => 'ro', isa => 'Bool', default=> 1);
+has 'statement_descriptor' => ('is' => 'ro', isa => 'Maybe[Str]');
 
 method form_fields {
     return (
         $self->fields_for('card'),
         $self->form_fields_for_metadata(),
         map { $_ => $self->get_form_field_value( $_ ) }
             grep { defined $self->$_ }
-                qw/amount currency customer description application_fee receipt_email capture/
+                qw/amount currency customer description application_fee receipt_email capture
+                   statement_descriptor/
     );
 }
 

lib/Net/Stripe/Plan.pm

@@ -7,10 +7,10 @@ extends 'Net::Stripe::Resource';
 
 # ABSTRACT: represent a Plan object from Stripe
 
-subtype 'StatementDescription',
+subtype 'StatementDescriptor',
     as 'Str',
     where { !defined($_) || $_ =~ /^[^<>"']{0,15}$/ },
-    message { "The statement description you provided '$_' must be 15 characters or less and not contain <>\"'." };
+    message { "The statement descriptor you provided '$_' must be 15 characters or less and not contain <>\"'." };
 
 has 'id'                => (is => 'ro', isa => 'Maybe[Str]', required => 1);
 has 'amount'            => (is => 'ro', isa => 'Maybe[Int]', required => 1);
@@ -19,13 +19,13 @@ has 'interval'          => (is => 'ro', isa => 'Maybe[Str]', required => 1);
 has 'interval_count'    => (is => 'ro', isa => 'Maybe[Int]', required => 0);
 has 'name'              => (is => 'ro', isa => 'Maybe[Str]', required => 1);
 has 'trial_period_days' => (is => 'ro', isa => 'Maybe[Int]');
-has 'statement_description' => ('is' => 'ro', isa => 'Maybe[StatementDescription]', required => 0);
+has 'statement_descriptor' => ('is' => 'ro', isa => 'Maybe[StatementDescriptor]', required => 0);
 
 method form_fields {
     return (
         map { $_ => $self->$_ }
             grep { defined $self->$_ }
-                qw/id amount currency interval interval_count name statement_description trial_period_days/
+                qw/id amount currency interval interval_count name statement_descriptor trial_period_days/
     );
 }
 

t/live.t

@@ -78,9 +78,11 @@ Plans: {
             interval => 'month',
             name => "Test Plan - $future",
             trial_period_days => 10,
+            statement_descriptor => 'Statement Descr',
         );
         isa_ok $plan, 'Net::Stripe::Plan',
             'I love it when a plan comes together';
+        is $plan->statement_descriptor, 'Statement Descr', 'plan statement_descriptor matches';
 
         my $newplan = $stripe->get_plan(plan_id => $id);
         isa_ok $newplan, 'Net::Stripe::Plan',
@@ -154,17 +156,19 @@ Charges: {
                 currency => 'usd',
                 card => $fake_card,
                 description => 'Wikileaks donation',
+                statement_descriptor => 'Statement Descr',
             );
         } 'Created a charge object';
         isa_ok $charge, 'Net::Stripe::Charge';
         for my $field (qw/id amount created currency description
-                          livemode paid refunded status/) {
+                          livemode paid refunded status statement_descriptor/) {
             ok defined($charge->$field), "charge has $field";
         }
         ok !$charge->refunded, 'charge is not refunded';
         ok $charge->paid, 'charge was paid';
         is $charge->status, 'paid', 'charge status is paid';
         ok $charge->captured, 'charge was captured';
+        is $charge->statement_descriptor, 'Statement Descr', 'charge statement_descriptor matches';
 
         # Check out the returned card object
         my $card = $charge->card;