[FIRRTL] Add more port-related functionality to instance ops #9125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwy7
commented
Oct 21, 2025
rwy7
commented
- getNumPorts
- getPortLocation
- getNumPorts - getPortLocation
seldridge
approved these changes
Oct 21, 2025
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
LGTM! These were definitely missing.
Should/could these be part of FInstanceLike?
dtzSiFive
approved these changes
Oct 21, 2025
Contributor
dtzSiFive
left a comment
dtzSiFive
left a comment
There was a problem hiding this comment.
LGTM.
Is this something that makes sense to expose on FInstanceLike ?
Contributor
Author
Yes I think that makes sense but I have been holding off on making changes to interfaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.