[ImportVerilog][MooreToCore] Implement CHandle import and lowering #9077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-moore-chandle
branch
3 times, most recently
from
a4a251e to
0c42566
Compare
Add end-to-end support for SystemVerilog `chandle`: - Import from Slang as `moore.chandle`. - Lower to `!llvm.ptr` in MooreToCore. - Treat `ref<chandle>` as a *by-ref SSA* value (no `hw.inout`). - Default-initialize to `llvm.mlir.zero : !llvm.ptr`. I also had to add `getDependentDialects` in MooreToCore to make this work. Please do let me know if this is the wrong place to do this, I got this from [this MLIR page](https://mlir.llvm.org/docs/PassManagement/?utm_source=chatgpt.com#dependent-dialects)
Scheremo
force-pushed
the
pr-moore-chandle
branch
from
0c42566 to
7df910c
Compare
fabianschuiki
approved these changes
Oct 10, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
Really cool, thanks for adding support for this! Just a thought on that !hw.inout wrapping a !llvm.ptr being broken in general. Guess we really need that !llhd.ref<T> type 😁
Scheremo
pushed a commit
to Scheremo/circt
that referenced
this pull request
Oct 10, 2025
…ering Re-lands llvm#9077 which was reverted because it was unsquashed. Add end-to-end support for SystemVerilog `chandle`: - Import from Slang as `moore.chandle`. - Lower to `!llvm.ptr` in MooreToCore. - Treat `ref<chandle>` as a *by-ref SSA* value (no `hw.inout`). - Default-initialize to `llvm.mlir.zero : !llvm.ptr`. I also had to add `getDependentDialects` in MooreToCore to make this work. Please do let me know if this is the wrong place to do this, I got this from [this MLIR page](https://mlir.llvm.org/docs/PassManagement/?utm_source=chatgpt.com#dependent-dialects)
Scheremo
pushed a commit
to Scheremo/circt
that referenced
this pull request
Oct 10, 2025
…ering Re-lands llvm#9077 which was reverted because it was unsquashed. Add end-to-end support for SystemVerilog `chandle`: - Import from Slang as `moore.chandle`. - Lower to `!llvm.ptr` in MooreToCore. - Treat `ref<chandle>` as a *by-ref SSA* value (no `hw.inout`). - Default-initialize to `llvm.mlir.zero : !llvm.ptr`.
Scheremo
pushed a commit
that referenced
this pull request
Oct 10, 2025
…ering Re-lands #9077 which was reverted because it was unsquashed. Add end-to-end support for SystemVerilog `chandle`: - Import from Slang as `moore.chandle`. - Lower to `!llvm.ptr` in MooreToCore. - Treat `ref<chandle>` as a *by-ref SSA* value (no `hw.inout`). - Default-initialize to `llvm.mlir.zero : !llvm.ptr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add end-to-end support for SystemVerilog
chandle:moore.chandle.!llvm.ptrin MooreToCore.ref<chandle>as a by-ref SSA value (nohw.inout).llvm.mlir.zero : !llvm.ptr.