[SeqToSV] Use XMR to set up async reset and preset of firreg under ifdef #8944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
added
FIRRTL
rwy7
force-pushed
the
fix-async-reg-reset-under-ifdef
branch
2 times, most recently
from
f477454 to
3ff7ba5
Compare
rwy7
changed the title
Contributor
Author
|
Updated to also fix the same issue for preset registers. |
seldridge
approved these changes
Sep 11, 2025
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
This looks great. Thank you for quickly getting this fixed!
I am also glad that all the infra was almost there to do this. 😌
| sv::BPAssignOp::create(builder, reg.reg.getLoc(), target, | ||
| reg.asyncResetValue); | ||
| } | ||
| builder.setInsertionPointAfter(ifOp); |
Member
There was a problem hiding this comment.
Same as above. Consider InsertionGuard. Suggestion only, non-blocking.
rwy7
force-pushed
the
fix-async-reg-reset-under-ifdef
branch
3 times, most recently
from
d77c1ed to
55a8c2e
Compare
With inline layers, firregs may now appear under ifdef blocks. This PR updates the generation of the reset IR to reference a firreg by XMR if the register is buried under an ifdef.
rwy7
force-pushed
the
fix-async-reg-reset-under-ifdef
branch
from
55a8c2e to
999e48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With inline layers, firregs may now appear under ifdef blocks. This PR updates the generation of the reset IR to reference a firreg by XMR if the register is buried under an ifdef.