fix(cli): improved support for native sidecar servers in linkerd authz
#14780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Extracted from #14566) The logic behind the `linkerd authz` command wasn't accounting for ports in init containers, so authorization policies pointing to those ports were not reported by the command. Say for example you had a strict auth policy for the `linkerd-admin` port, allowing only access from prometheus. For emojivoto's web workload you could set that up like this: ```yaml apiVersion: policy.linkerd.io/v1beta3 kind: Server metadata: annotations: name: admin namespace: emojivoto spec: accessPolicy: deny podSelector: matchLabels: app: web-svc port: linkerd-admin proxyProtocol: HTTP/1 --- apiVersion: policy.linkerd.io/v1alpha1 kind: MeshTLSAuthentication metadata: namespace: emojivoto name: prometheus spec: identities: - "prometheus.linkerd-viz.serviceaccount.identity.linkerd.cluster.local" --- apiVersion: policy.linkerd.io/v1alpha1 kind: AuthorizationPolicy metadata: namespace: emojivoto name: web-http-sa spec: targetRef: group: policy.linkerd.io kind: Server name: admin requiredAuthenticationRefs: - name: prometheus kind: MeshTLSAuthentication group: policy.linkerd.io ``` Invoking `linkerd authz` would return nothing, but after this change we can see the auth: ``` $ linkerd authz -n emojivoto deploy/web ROUTE SERVER AUTHORIZATION_POLICY SERVER_AUTHORIZATION * admin web-http-sa ```
adleong
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Extracted from #14566)
The logic behind the
linkerd authzcommand wasn't accounting for ports in init containers, so authorization policies pointing to those ports were not reported by the command.Say for example you had a strict auth policy for the
linkerd-adminport, allowing only access from prometheus. For emojivoto's web workload you could set that up like this:Invoking
linkerd authzwould return nothing, but after this change we can see the auth: