test(CI): move go test timeout to justfile #13927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Apr 11, 2025
|
|
||
| go-test: | ||
| needs: meta | ||
| if: needs.meta.outputs.changed == 'true' |
Member
There was a problem hiding this comment.
It would still be valuable to have a timeout on the workflow itself in case we hang in another step. Maybe 30 mins?
Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-test CI workflow specifies at 10m timeout. However, if a test exceeds this timeout (for example if it is deadlocked) then CI terminates the job and the go test output doesn't give us any clues about which test specifically was running. This makes it hard to identify what caused the failure.
We move the 10m timeout from the CI workflow into the
go-testjustfile recipe. This causesgo testto exit with a more informative error message once the timeout is reached, instead of being terminated by CI.