Skip to content

Commit afbd4f2

Browse files
authored
test(CI): move go test timeout to justfile (#13927)
The go-test CI workflow specifies at 10m timeout. However, if a test exceeds this timeout (for example if it is deadlocked) then CI terminates the job and the go test output doesn't give us any clues about which test specifically was running. This makes it hard to identify what caused the failure. We move the 10m timeout from the CI workflow into the `go-test` justfile recipe. This causes `go test` to exit with a more informative error message once the timeout is reached, instead of being terminated by CI. Signed-off-by: Alex Leong <alex@buoyant.io> --------- Signed-off-by: Alex Leong <alex@buoyant.io>
1 parent b4bffda commit afbd4f2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/go.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
go-test:
5050
needs: meta
5151
if: needs.meta.outputs.changed == 'true'
52-
timeout-minutes: 10
52+
timeout-minutes: 30
5353
runs-on: ubuntu-24.04
5454
container: ghcr.io/linkerd/dev:v45-go
5555
steps:

justfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ go-lint *flags:
1818
golangci-lint run {{ flags }}
1919

2020
go-test:
21-
LINKERD_TEST_PRETTY_DIFF=1 gotestsum -- -race -v -mod=readonly ./...
21+
LINKERD_TEST_PRETTY_DIFF=1 gotestsum -- -race -v -mod=readonly --timeout 10m ./...
2222

2323
##
2424
## Rust

0 commit comments

Comments
 (0)