Continuous memory profiling #4572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2025
Draft
deuszx
approved these changes
Sep 15, 2025
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
8ce35c8 to
d69326d
Compare
ndr-ds
force-pushed
the
09-15-continuous_memory_profiling
branch
2 times, most recently
from
98e8680 to
af8515a
Compare
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
2 times, most recently
from
23a8d18 to
a043826
Compare
ndr-ds
force-pushed
the
09-15-continuous_memory_profiling
branch
from
af8515a to
8d50ce2
Compare
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
a043826 to
20adbf7
Compare
ndr-ds
force-pushed
the
09-15-continuous_memory_profiling
branch
from
8d50ce2 to
84191d9
Compare
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
20adbf7 to
ef98053
Compare
ndr-ds
force-pushed
the
09-15-continuous_memory_profiling
branch
from
84191d9 to
6ce4c71
Compare
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
ef98053 to
eee424e
Compare
ndr-ds
force-pushed
the
09-15-continuous_memory_profiling
branch
from
6ce4c71 to
aef1bc5
Compare
Base automatically changed from
09-15-add_feature_to_use_jemalloc_as_memory_allocator
to
main
September 16, 2025 20:21
ndr-ds
force-pushed
the
09-15-continuous_memory_profiling
branch
from
aef1bc5 to
ded3152
Compare
Merge activity
|
deuszx
pushed a commit
that referenced
this pull request
Sep 19, 2025
For debugging production memory issues, ideally we'll have continuous memory profiling always on. This exposes a couple endpoints: * One that generates a pprof and returns it once the endpoint is queried * One that generates a flamegraph and returns it once the endpoint is queried The former will be used by Alloy on the deployment side, to generate profiles every 30 seconds or so. It shows no visible performance regression. Deployed a network with this and the `linera-infra` changes, saw the memory flamegraphs on Pyroscope, and managed to curl the flamegraph endpoint and get a memory profile svg returned to me.  - Nothing to do / These changes follow the usual release cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For debugging production memory issues, ideally we'll have continuous memory profiling always on.
Proposal
This exposes a couple endpoints:
The former will be used by Alloy on the deployment side, to generate profiles every 30 seconds or so. It shows no visible performance regression.
Test Plan
Deployed a network with this and the
linera-infrachanges, saw the memory flamegraphs on Pyroscope, and managed to curl the flamegraph endpoint and get a memory profile svg returned to me.Release Plan