Add feature to use jemalloc as memory allocator #4571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2025
Merged
This was referenced Sep 15, 2025
Draft
deuszx
approved these changes
Sep 15, 2025
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
8ce35c8 to
d69326d
Compare
ndr-ds
force-pushed
the
09-03-optimize_rocksdb_prefix_searches
branch
2 times, most recently
from
4da37f2 to
c18be16
Compare
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
d69326d to
23a8d18
Compare
ndr-ds
changed the base branch from
09-03-optimize_rocksdb_prefix_searches
to
graphite-base/4571
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
23a8d18 to
a043826
Compare
ndr-ds
force-pushed
the
graphite-base/4571
branch
from
c18be16 to
860f522
Compare
ndr-ds
changed the base branch from
graphite-base/4571
to
09-03-optimize_rocksdb_prefix_searches
ndr-ds
changed the base branch from
09-03-optimize_rocksdb_prefix_searches
to
graphite-base/4571
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
a043826 to
20adbf7
Compare
ndr-ds
changed the base branch from
graphite-base/4571
to
09-03-optimize_rocksdb_prefix_searches
ndr-ds
changed the base branch from
09-03-optimize_rocksdb_prefix_searches
to
graphite-base/4571
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
20adbf7 to
ef98053
Compare
ndr-ds
force-pushed
the
graphite-base/4571
branch
from
7ba0612 to
22c5f8e
Compare
ndr-ds
changed the base branch from
graphite-base/4571
to
09-03-optimize_rocksdb_prefix_searches
ndr-ds
force-pushed
the
09-03-optimize_rocksdb_prefix_searches
branch
from
22c5f8e to
f800271
Compare
ndr-ds
force-pushed
the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
from
ef98053 to
eee424e
Compare
Base automatically changed from
09-03-optimize_rocksdb_prefix_searches
to
main
September 16, 2025 19:39
ndr-ds
deleted the
09-15-add_feature_to_use_jemalloc_as_memory_allocator
branch
deuszx
pushed a commit
that referenced
this pull request
Sep 19, 2025
## Motivation jemalloc is more performant than the system allocator (and was even the Rust default for a while) ## Proposal Add a feature that when enabled will use jemalloc as the allocator. We might decide to have this feature on by default eventually, but for now it'll be used for memory profiling, which is coming in the following PRs. ## Test Plan Deployed a network with this featured turned on, saw a slight performance improvement, and tested with the profiling code. ## Release Plan - Nothing to do / These changes follow the usual release cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
jemalloc is more performant than the system allocator (and was even the Rust default for a while)
Proposal
Add a feature that when enabled will use jemalloc as the allocator. We might decide to have this feature on by default eventually, but for now it'll be used for memory profiling, which is coming in the following PRs.
Test Plan
Deployed a network with this featured turned on, saw a slight performance improvement, and tested with the profiling code.
Release Plan