basichost: move EvtLocalAddrsChanged to addrs_manager #3355
+338
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/obs-addr-manager-move
branch
from
1b4f6c6 to
7ceafe9
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
91d3854 to
611df04
Compare
sukunrt
force-pushed
the
sukun/obs-addr-manager-move
branch
from
7ceafe9 to
b7f0784
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
611df04 to
8be2504
Compare
sukunrt
force-pushed
the
sukun/obs-addr-manager-move
branch
5 times, most recently
from
c0a8a78 to
cc0711a
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
2 times, most recently
from
b8d1eab to
d388884
Compare
sukunrt
force-pushed
the
sukun/obs-addr-manager-move
branch
from
cc0711a to
7a01719
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
d388884 to
4d77c2b
Compare
sukunrt
force-pushed
the
sukun/obs-addr-manager-move
branch
from
7a01719 to
771b390
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
4d77c2b to
51add1c
Compare
sukunrt
force-pushed
the
sukun/obs-addr-manager-move
branch
from
771b390 to
6a09306
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
51add1c to
2346193
Compare
MarcoPolo
requested changes
Aug 18, 2025
Collaborator
MarcoPolo
left a comment
MarcoPolo
left a comment
There was a problem hiding this comment.
I think it would be better if we did the following:
- Add a method to the Peerstore interface for
HandleLocalAddrUpdate(currentAddrs []multiaddr.Multiaddr, lastAddrs []multiaddr.Multiaddr) error. - Have this method handle all the peerstore related code including the signed peer records.
- Move emitting here instead of basic host.
We'll deprecate this event, but we still have to keep sending this for a few more releases. More importantly, we need to update the peerstore with the host's addresses and it's better to do this *before* sending update events so that consumers of the event can rely on the host addrs being updated in the peerstore.
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
2 times, most recently
from
3846f17 to
f9389e0
Compare
Member
Author
|
I've made this change to adding a method on the peerstore. I'm not convinced about it though.
|
sukunrt
commented
Sep 16, 2025
core/peerstore/peerstore.go
Outdated
Comment on lines
76
to
77
| // This method should only be used to update the addresses of the Host that owns the peerstore. | ||
| UpdateHostAddrs(hostID peer.ID, currentAddrs, removedAddrs, peerRecordAddrs []ma.Multiaddr) error |
Member
Author
There was a problem hiding this comment.
Keeping the signature this way to avoid attaching a peerstore to a host. That would complicate the host creation even more.
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
f9389e0 to
e675e47
Compare
sukunrt
commented
Sep 16, 2025
| } | ||
| } | ||
|
|
||
| func (ps *pstoremem) UpdateHostAddrs(hostID peer.ID, currentAddrs, removedAddrs, peerRecordAddrs []ma.Multiaddr) error { |
Member
Author
There was a problem hiding this comment.
There's a small change here. All host's now will store the signed peer record in th e peerstore. This I think is okay because identify is configured to disable sending signed peer records.
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
e675e47 to
ecab374
Compare
Collaborator
I think you're right. I'm sorry for the false lead. I'm not a fan of the PeerStore changes in the second commit. I've reviewed the first commit again, and thinking about it a bit more I think it's fine. Please drop the second commit, and I'll approve |
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
ecab374 to
4fb69b6
Compare
Member
Author
|
Done. move it backed to the previous commit. |
MarcoPolo
approved these changes
Sep 25, 2025
MarcoPolo
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll deprecate this event, but we still have to keep sending this for a few more releases. More importantly, we need to update the peerstore with the host's addresses and it's better to do this before sending update events so that consumers of the event can rely on the host addrs being updated in the peerstore.