connmgr: remove WithEmergencyTrim #3217
Merged
+5
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option `WithEmergencyTrim` intended to trim connections where there was a memory emergency. The API was very confusing. To use it correctly you had to use the `WithEmergencyTrim` option and then do `watchdog.HeapDriven(...)` to run the goroutine that would trigger this in time of a memory emergency. As there's no correct usage of this API(https://github.com/search?q=WithEmergencyTrim&type=code&p=1), I'm removing this and exporting a ForceTrim method that users can call using any watchdog style memory tracking implementation.
MarcoPolo
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option
WithEmergencyTrimintended to trim connections where there was a memory emergency. The API was very confusing. To use it correctly you had to use theWithEmergencyTrimoption and then dowatchdog.HeapDriven(...)to run the goroutine that would trigger this in time of a memory emergency.As there's no correct usage of this
API(https://github.com/search?q=WithEmergencyTrim&type=code&p=1), I'm removing this and exporting a ForceTrim method that users can call using any watchdog style memory tracking implementation.
closes #3216