-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
kind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)
Description
This Option is broken. It expects users to call:
watchdog.SystemDriven
or watchdog.HeapDriven
to actually do the trimming in times of an emergency, but this isn't documented anywhere. No user of this option calls these methods(https://github.com/search?q=WithEmergencyTrim&type=code)
I propose removing this completely. We should expose a ForceTrim
option that closes the connection in times of an emergency, but the application should decide when it's necessary to ForceTrim the connection.
Metadata
Metadata
Assignees
Labels
kind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)