sfe/test: Configure SFE to use a zendesk-test-srv #8354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
force-pushed
the
zendesk-test-srv
branch
3 times, most recently
from
1e294fe to
867b23f
Compare
beautifulentropy
force-pushed
the
zendesk-test-srv
branch
from
867b23f to
628970d
Compare
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
1 similar comment
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
aarongable
reviewed
Aug 14, 2025
aarongable
requested review from
a team and
jsha
and removed request for
a team
Co-authored-by: Aaron Gable <[email protected]>
aarongable
approved these changes
Aug 15, 2025
jprenken
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/zendeskfake:
Address some optional comments from #8320.
sfe/zendesk:
Address some optional comments from #8320.
ratelimits/overriderequests:
test/zendesk-test-srv:
Testing the user experience of the entire submission flow will require a non-nil zendeskClient in the SFE. Add a new test-only Zendesk server implementation that allows us to configure and use the Zendesk client in the SFE.
sfe/templates:
In a future PR, new Content Security Policy headers necessary to secure our override request forms will disallow inline CSS. To keep that PR focused (and the CSS diff easier to parse), this change moves the existing CSS to a static file and references it in the existing HTML template.
sfe/sfe:
Configure and assign the zendeskClient in config-next.
cmd/sfe/main.go:
Change AccountID configuration field to match AccountURI present in the form.