sfe/zendesk: Add a Zendesk API client implementation #8320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
force-pushed
the
sfe-zendesk-get-fetch
branch
3 times, most recently
from
930d7af to
b70cc19
Compare
beautifulentropy
force-pushed
the
sfe-zendesk-get-fetch
branch
from
b70cc19 to
edaac0e
Compare
aarongable
reviewed
Aug 7, 2025
aarongable
requested review from
a team and
jprenken
and removed request for
a team
jprenken
approved these changes
Aug 13, 2025
aarongable
approved these changes
Aug 14, 2025
beautifulentropy
added a commit
that referenced
this pull request
Aug 15, 2025
**test/zendeskfake:** Address some optional comments from #8320. **sfe/zendesk:** Address some optional comments from #8320. **ratelimits/overriderequests**: - Remove unused constants that are not yet necessary. - Remove Fundraising from tickets, we'll handle this value at submission time. - Comment the various Create*OverrideTicket functions. - Pass the correct rate limit for the ticket being created. **test/zendesk-test-srv:** Testing the user experience of the entire submission flow will require a non-nil zendeskClient in the SFE. Add a new test-only Zendesk server implementation that allows us to configure and use the Zendesk client in the SFE. **sfe/templates**: In a future PR, new Content Security Policy headers necessary to secure our override request forms will disallow inline CSS. To keep that PR focused (and the CSS diff easier to parse), this change moves the existing CSS to a static file and references it in the existing HTML template. **sfe/sfe:** Configure and assign the zendeskClient in config-next. **cmd/sfe/main.go:** Change AccountID configuration field to match AccountURI present in the form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sfe/zendesk: Add a Zendesk client implementation that supports all functionality required for storing and loading rate limit override requests.
test/zendeskfake: Add a fake Zendesk server implementation supporting all behavior expected by the sfe/zendesk client.
cmd/sfe: Add configuration to support an optional Zendesk client in the SFE.
sfe: Add the optional Zendesk client to SelfServiceFrontEndImpl and its constructor, NewSelfServiceFrontEndImpl.
ratelimits/overriderequests: Add helpers for creating Zendesk tickets for supported rate limit override requests. Include expected display names for Zendesk custom fields related to override request storage. These match the documentation I've drafted for our SRE team.
Closes #8164