Rm retriever kwargs #7013
Merged
Rm retriever kwargs #7013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
baskaryan
commented
Jul 1, 2023
langchain/schema.py
Outdated
|
|
||
| @abstractmethod | ||
| def get_relevant_documents( | ||
| self, query: str, *, callbacks: Callbacks = None, **kwargs: Any |
Collaborator
Author
There was a problem hiding this comment.
need to think a bit more about backwards compatibility here
baskaryan
commented
Jul 2, 2023
| *, | ||
| run_manager: Optional[AsyncCallbackManagerForRetrieverRun], | ||
| **kwargs: Any, | ||
| self, query: str, *, run_manager: Optional[AsyncCallbackManagerForRetrieverRun] |
Collaborator
Author
There was a problem hiding this comment.
just noticing there's decent amount of classes where run_manager is typed as Optional, some where it has a default val of None. on base it's not optional and has no default. guessing discrepancy is unintentional @hinthornw @nfcampos?
Collaborator
Author
There was a problem hiding this comment.
will save updating that for a sep pr
Collaborator
There was a problem hiding this comment.
It should be required. I had originally incorrectly made optional
bdonkey
added a commit
to bdonkey/langchain
that referenced
this pull request
Jul 3, 2023
* master: (212 commits) Add SpacyEmbeddings class (langchain-ai#6967) docs: commented out `editUrl` option (langchain-ai#6440) Remove duplicate mongodb integration doc (langchain-ai#7006) Update get_started.mdx (langchain-ai#7005) openapi chain nit (langchain-ai#7012) Fix sample in FAISS section (langchain-ai#7050) Fix typo in google_places_api.py (langchain-ai#7055) move base prompt to schema (langchain-ai#6995) added `Brave Search` document_loader (langchain-ai#6989) Add JSON Lines support to JSONLoader (langchain-ai#6913) Vectara upd2 (langchain-ai#6506) docstrings `document_loaders` 2 (langchain-ai#6890) docstrings `document_loaders` 1 (langchain-ai#6847) Added filter and delete all option to delete function in Pinecone integration, updated base VectorStore's delete function (langchain-ai#6876) bump 221 (langchain-ai#7047) Rm retriever kwargs (langchain-ai#7013) Polish reference docs (langchain-ai#7045) Support params on GoogleSearchApiWrapper (langchain-ai#6810) (langchain-ai#7014) Fix typo (langchain-ai#7023) Fix openai multi functions agent docs (langchain-ai#7028) ...
vowelparrot
pushed a commit
that referenced
this pull request
Jul 4, 2023
Doesn't actually limit the Retriever interface but hopefully in practice it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't actually limit the Retriever interface but hopefully in practice it does