Skip to content

Conversation

@ofermend
Copy link
Contributor

Update to Vectara integration

  • By user request added "add_files" to take advantage of Vectara capabilities to process files on the backend, without the need for separate loading of documents and chunking in the chain.

  • Updated vectara.ipynb example notebook to be broader and added testing of add_file()

    @hwchase17 - project lead

ofermend added 2 commits June 15, 2023 17:43
Updated docs
Added testing of add_files() functionality, and also testing for filtering
@vercel
Copy link

vercel bot commented Jun 20, 2023

@ofermend is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 2, 2023 7:05pm

Copy link
Contributor

@rlancemartin rlancemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rlancemartin
Copy link
Contributor

@ofermend can you please have a look at the Lint errors -

langchain/vectorstores/vectara.py:153: error: Argument "files" to "post" of "Session" has incompatible type "Dict[str, Sequence[Iterable[Sequence[object]]]]"; expected "Optional[Union[Mapping[str, Union[Union[SupportsRead[Union[str, bytes]], str, bytes], Tuple[Optional[str], Union[SupportsRead[Union[str, bytes]], str, bytes]], Tuple[Optional[str], Union[SupportsRead[Union[str, bytes]], str, bytes], str], Tuple[Optional[str], Union[SupportsRead[Union[str, bytes]], str, bytes], str, Mapping[str, str]]]], Iterable[Tuple[str, Union[Union[SupportsRead[Union[str, bytes]], str, bytes], Tuple[Optional[str], Union[SupportsRead[Union[str, bytes]], str, bytes]], Tuple[Optional[str], Union[SupportsRead[Union[str, bytes]], str, bytes], str], Tuple[Optional[str], Union[SupportsRead[Union[str, bytes]], str, bytes], str, Mapping[str, str]]]]]]]"  [arg-type]
langchain/vectorstores/vectara.py:194: error: Unsupported target for indexed assignment ("Optional[Dict[Any, Any]]")  [index]

We can get this in once those are resolved.

@ofermend
Copy link
Contributor Author

ofermend commented Jul 1, 2023

Should be fixed now

@rlancemartin
Copy link
Contributor

Thanks! Just added minor formatting.

@rlancemartin rlancemartin merged commit 153b56d into langchain-ai:master Jul 2, 2023
bdonkey added a commit to bdonkey/langchain that referenced this pull request Jul 3, 2023
* master: (212 commits)
  Add SpacyEmbeddings class (langchain-ai#6967)
  docs: commented out `editUrl` option (langchain-ai#6440)
  Remove duplicate mongodb integration doc (langchain-ai#7006)
  Update get_started.mdx (langchain-ai#7005)
  openapi chain nit (langchain-ai#7012)
  Fix sample in FAISS section (langchain-ai#7050)
  Fix typo in google_places_api.py (langchain-ai#7055)
  move base prompt to schema (langchain-ai#6995)
  added `Brave Search` document_loader (langchain-ai#6989)
  Add JSON Lines support to JSONLoader (langchain-ai#6913)
  Vectara upd2 (langchain-ai#6506)
  docstrings `document_loaders` 2 (langchain-ai#6890)
  docstrings `document_loaders` 1 (langchain-ai#6847)
  Added filter and delete all option to delete function in Pinecone integration, updated base VectorStore's delete function (langchain-ai#6876)
  bump 221 (langchain-ai#7047)
  Rm retriever kwargs (langchain-ai#7013)
  Polish reference docs (langchain-ai#7045)
  Support params on GoogleSearchApiWrapper (langchain-ai#6810) (langchain-ai#7014)
  Fix typo (langchain-ai#7023)
  Fix openai multi functions agent docs (langchain-ai#7028)
  ...
vowelparrot pushed a commit that referenced this pull request Jul 4, 2023
Update to Vectara integration 
- By user request added "add_files" to take advantage of Vectara
capabilities to process files on the backend, without the need for
separate loading of documents and chunking in the chain.
- Updated vectara.ipynb example notebook to be broader and added testing
of add_file()
 
  @hwchase17 - project lead

---------

Co-authored-by: rlm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants