Skip to content

Remove emscripten support#92

Merged
kulp merged 1 commit intodevelopfrom
remove-emscripten-support
Jul 3, 2021
Merged

Remove emscripten support#92
kulp merged 1 commit intodevelopfrom
remove-emscripten-support

Conversation

@kulp
Copy link
Copy Markdown
Owner

@kulp kulp commented Jul 3, 2021

Support for running the tenyr tools under emscripten has been a useful experiment in portability, and a similar capability (or compiling to Wasm) should be resurrected in time. When the online demo was removed in 5231a1c, I said

On the other hand, building for node.js (via asm.js or wasm) is a valuable capability that will be maintained for 1.0.

and if possible this intention should be maintained.

However, emscripten support has been broken for a while (insofar as I did not keep up with breakages introduced by newer emscripten versions), and the natural use of NODERAWFS is not compatible with the current Make-based test harness (which tries to use absolute paths).

Making emscripten work again with the current build system is feasible, but would work against #50 and #53, which are more important for v1.0.0 support than emscripten support is. After those two issues are resolved, we can try to reinstate node.js support (or some other emscripten-like target) for v1.0.0 if time permits.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2021

Codecov Report

Merging #92 (ea37de4) into develop (5e3c059) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #92     +/-   ##
=========================================
- Coverage     96.6%   96.6%   -0.1%     
=========================================
  Files           35      34      -1     
  Lines         2652    2650      -2     
  Branches       468     468             
=========================================
- Hits          2563    2561      -2     
  Misses          70      70             
  Partials        19      19             
Impacted Files Coverage Δ
src/tsim.c 94.9% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3c059...ea37de4. Read the comment docs.

@kulp kulp marked this pull request as ready for review July 3, 2021 18:20
@kulp kulp merged commit 6c27abd into develop Jul 3, 2021
@kulp kulp deleted the remove-emscripten-support branch July 3, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant