fix: ensure integer comparison for disk fsync latency in etcd validation

[redscholar]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:

[kubesphere-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [redscholar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Code Review

This pull request updates the ETCD disk fsync latency assertion by adding integer casting to the comparison. The review highlights two critical issues: the task was incorrectly moved out of its conditional block, which may lead to template errors if dependencies are missing, and the comparison logic uses 'ge' instead of 'le', meaning the check currently fails when latency is acceptable and passes when it exceeds the maximum allowed threshold.

[gemini-code-assist]

There are two critical issues introduced or maintained in this change:

1. Indentation/Logic Flow: The assertion task has been moved out of the conditional block (line 38). Since it depends on .fio_result (registered at line 43), it will now cause a template error if fio is not installed or the test is skipped. It should remain indented within the inner block to ensure it only runs when the test results are available.
2. Comparison Logic: The use of ge (greater than or equal) is incorrect for a performance check where a maximum latency is specified. The assertion currently passes if the latency is higher than the limit and fails if it is lower. It should use le (less than or equal) to ensure the measured latency does not exceed the threshold.

While the addition of integer casting correctly addresses the type mismatch issue, these structural and logic errors must be resolved.

        - name: ETCD | Assert disk fsync latency meets requirements
          assert:
            that: (index (.fio_result.stdout.jobs | first) "sync" "lat_ns" "percentile" "90.000000") | int | le (int .cluster_require.etcd_disk_wal_fysnc_duration_seconds)
            fail_msg: >-
              The 90th percentile fsync latency is {{ index (.fio_result.stdout.jobs | first) "sync" "lat_ns" "percentile" "90.000000" }}ns, which exceeds the maximum allowed: {{ .cluster_require.etcd_disk_wal_fysnc_duration_seconds }}ns.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud