Skip to content

Commit e793680

Browse files
committed
fix: ensure integer comparison for disk fsync latency in etcd validation
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
1 parent fa2fdb9 commit e793680

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

  • builtin/core/roles/precheck/etcd/tasks

builtin/core/roles/precheck/etcd/tasks/main.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@
4242
fio --rw=write --ioengine=sync --fdatasync=1 --directory={{ .tmp_dir }}/etcd/test-data --size=22m --bs=2300 --name=mytest --output-format=json
4343
register: fio_result
4444
register_type: json
45-
- name: ETCD | Assert disk fsync latency meets requirements
46-
assert:
47-
that: (index (.fio_result.stdout.jobs | first) "sync" "lat_ns" "percentile" "90.000000") | ge .cluster_require.etcd_disk_wal_fysnc_duration_seconds
48-
fail_msg: >-
49-
The 90th percentile fsync latency is {{ index (.fio_result.stdout.jobs | first) "sync" "lat_ns" "percentile" "90.000000" }}ns, which exceeds the maximum allowed: {{ .cluster_require.etcd_disk_wal_fysnc_duration_seconds }}ns.
45+
- name: ETCD | Assert disk fsync latency meets requirements
46+
assert:
47+
that: (index (.fio_result.stdout.jobs | first) "sync" "lat_ns" "percentile" "90.000000") | int | ge (int .cluster_require.etcd_disk_wal_fysnc_duration_seconds)
48+
fail_msg: >-
49+
The 90th percentile fsync latency is {{ index (.fio_result.stdout.jobs | first) "sync" "lat_ns" "percentile" "90.000000" }}ns, which exceeds the maximum allowed: {{ .cluster_require.etcd_disk_wal_fysnc_duration_seconds }}ns.
5050
always:
5151
- name: ETCD | Clean up fio test data directory
5252
command: rm -rf {{ .tmp_dir }}/etcd/test-data

0 commit comments

Comments
 (0)