Revise mobile nav to Bootstrap structure, aligned with Docsy#54700
Revise mobile nav to Bootstrap structure, aligned with Docsy#54700ritorhymes wants to merge 1 commit intokubernetes:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
A nit: this is not a refactor in the way people usually use the word. |
|
What would you recommend as the best way to categorize / describe it? |
|
/retitle Revise mobile nav to Bootstrap structure, aligned with Docsy |
|
"Revise" not "refactor". |
|
That’s fair. I was on the fence about using refactor versus migrate, but I used refactor because the intent was to keep the core UX behaviors functionally near-identical while aligning the implementation with the already established dependencies. Reworked is also good too. |
lmktfy
left a comment
There was a problem hiding this comment.
If this gets an LGTM I am happy to be the approver for it.
591e904 to
ccacdfe
Compare
|
Might help with #54801 |
ccacdfe to
0350d8b
Compare
Reworks the mobile header/navigation to use Bootstrap collapse-driven structure and behavior in a Docsy-aligned implementation. Replaces the legacy pushmenu flow with a right-side mobile drawer pattern built on Bootstrap primitives and existing site navigation data. Preserves desktop navbar behavior while keeping the mobile UI visually near-identical to the pre-refactored version. Centers the mobile logo in the header, fixing the offset left quirk. Updates versions/languages mobile accordion behavior so both sections are no longer stuck in an always-open state. The versions section is closed by default since it is not universally essential to see immediately. Languages stays open by default to let users quickly navigate to their needed language. Localizes mobile navigation ARIA labels for toggle/close controls to improve accessibility and translation support. Signed-off-by: Rito Rhymes <rito@ritovision.com>
0350d8b to
4f67da8
Compare
Summary
To better align with the Docsy migration #41171, which integrates Bootstrap, this PR reworks the mobile header/navigation to use Bootstrap collapse-driven structure and behavior in a Docsy-aligned implementation. The resulting UI is near-identical to the original in form and function with several bug fixes implemented, no impact on desktop, and better maintainability than the prior custom coded solution. A migration plan to Docsy 0.7 with Bootstrap 5.2 is included.
Changes
Replaces the legacy pushmenu flow with a right-side mobile drawer pattern built on Bootstrap primitives and existing site navigation data.
Updates versions/languages mobile accordion behavior so both sections are no longer stuck in an always-open state. The versions section is closed by default since it is not universally essential to see immediately. Languages stays open by default to let users quickly navigate to their needed language.
Localizes mobile navigation ARIA labels for toggle/close controls to improve accessibility and translation support.
Migration Plan for Docsy 0.7 with Bootstrap 5.2
Required for BS5.2 compatibility
Out of scope (optional follow-up)
A) Migrate Bootstrap collapse API calls to native BS5 instances
B) Full jQuery-to-vanilla DOM rewrite in nav.js and legacy-script.js
C) Convert current collapse-based drawer to BS5 offcanvas
Why jQuery calls can survive this migration