Skip to content

test(clusterloader2): add unit test for ConvertSampleToHistogram #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VedantMadane wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(clusterloader2): add unit test for ConvertSampleToHistogram #3872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions clusterloader2/pkg/measurement/util/histogram_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,3 +150,24 @@ func TestHistogramQuantile(t *testing.T) {
}
}
}

func TestConvertSampleToHistogram(t *testing.T) {
sample := &model.Sample{
Metric: model.Metric{
"name": "test_metric",
model.BucketLabel: "1.0",
},
Value: 5,
}
Comment on lines +155 to +161

@Qqkyu Qqkyu May 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to cover the ConvertSampleToHistogram function with UTs, let's use the table driven tests like other tests from this file. Additionally we should add a test case for multi-bucket sample set

hist := NewHistogram(nil)
ConvertSampleToHistogram(sample, hist)

expectedLabels := map[string]string{"name": "test_metric"}
if !reflect.DeepEqual(hist.Labels, expectedLabels) {
t.Errorf("expected labels %v, got %v", expectedLabels, hist.Labels)
}

if hist.Buckets["1.0"] != 5 {
t.Errorf("expected bucket 1.0 to have value 5, got %d", hist.Buckets["1.0"])
}
}