-
Notifications
You must be signed in to change notification settings - Fork 1.7k
updating all images to latest #4069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
we could update again with #3965 but I think it's not critical |
|
|
||
| // Image defines the loadbalancer image:tag | ||
| const Image = "docker.io/kindest/haproxy:v20230606-42a2262b" | ||
| const Image = "docker.io/kindest/haproxy:v20251211-v0.29.0-alpha-100-g82a92c5d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smoke tested locally, seems fine.
$ cat $HOME/kind-ha.yaml
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
- role: control-plane
- role: control-plane
$ kind create cluster --config=$HOME/kind-ha.yaml
Creating cluster "kind" ...
✓ Ensuring node image (kindest/node:v1.34.2) 🖼
✓ Preparing nodes 📦 📦 📦
✓ Configuring the external load balancer ⚖️
✓ Writing configuration 📜
✓ Starting control-plane 🕹️
✓ Installing CNI 🔌
✓ Installing StorageClass 💾
✓ Joining more control-plane nodes 🎮
Set kubectl context to "kind-kind"
You can now use your cluster with:
kubectl cluster-info --context kind-kind
Not sure what to do next? 😅 Check out https://kind.sigs.k8s.io/docs/user/quick-start/
$ kubectl get po -A
NAMESPACE NAME READY STATUS RESTARTS AGE
kube-system coredns-66bc5c9577-26ct8 1/1 Running 0 50s
kube-system coredns-66bc5c9577-sw2p8 1/1 Running 0 50s
kube-system etcd-kind-control-plane 1/1 Running 0 58s
kube-system etcd-kind-control-plane2 1/1 Running 0 24s
kube-system etcd-kind-control-plane3 1/1 Running 0 14s
kube-system kindnet-86km5 1/1 Running 0 16s
kube-system kindnet-qnkn8 1/1 Running 0 26s
kube-system kindnet-xks7f 1/1 Running 0 50s
kube-system kube-apiserver-kind-control-plane 1/1 Running 0 58s
kube-system kube-apiserver-kind-control-plane2 1/1 Running 0 24s
kube-system kube-apiserver-kind-control-plane3 1/1 Running 0 14s
kube-system kube-controller-manager-kind-control-plane 1/1 Running 0 58s
kube-system kube-controller-manager-kind-control-plane2 1/1 Running 0 24s
kube-system kube-controller-manager-kind-control-plane3 1/1 Running 0 14s
kube-system kube-proxy-f6mvv 1/1 Running 0 26s
kube-system kube-proxy-s4nj7 1/1 Running 0 16s
kube-system kube-proxy-vvtk5 1/1 Running 0 50s
kube-system kube-scheduler-kind-control-plane 1/1 Running 0 58s
kube-system kube-scheduler-kind-control-plane2 1/1 Running 0 24s
kube-system kube-scheduler-kind-control-plane3 1/1 Running 0 14s
local-path-storage local-path-provisioner-5c4cdb564f-cfbcj 1/1 Running 0 49s|
/lgtm |
|
Ah, that's going to be a problem ... |
|
Only 1.33 is impacted, we can consider something like configuring CI to skip these tests on 1.33, but we need to discuss in kubernetes/kubernetes#135214 |
pkg/apis/config/defaults/image.go
Outdated
|
|
||
| // Image is the default for the Config.Image field, aka the default node image. | ||
| const Image = "kindest/node:v1.34.0@sha256:7416a61b42b1662ca6ca89f02028ac133a309a2a30ba309614e8ec94d976dc5a" | ||
| const Image = "kindest/node:v1.34.2@sha256:745f8ed46d8e99517774768227fd1a0af34a6bf395aef9c7ed98fbce0e263918" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should do 1.34.3
0983ebf to
d00590d
Compare
d00590d to
b34dab4
Compare
|
trying runc 1.2.x in CI here |
b34dab4 to
57ed4da
Compare
2a5830b to
36ee7a6
Compare
|
Ok, so we can use runc 1.2.x as a stopgap, but eventually this is a problem because we're not aligned with containerd, and runc is already on 1.4.0 now. We really need a better solution to kubernetes/kubernetes#135214 |
|
/retest pull-kind-e2e-kubernetes-1-31 seems to be a minor flake, one test case |
This comment was marked as resolved.
This comment was marked as resolved.
|
/retest |
|
Jobs are happy, looks good. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We upgraded to runc 1.3.0 in kind v0.28, so this kind of stinks, but it is a ~fully patched runc release that does not break 1.33 tests. If I had more time, I'd fix the 1.33 tests, but I want to get us ready for k8s 1.35, and runc 1.2.9 should be OK for now. |
|
Thankfully after that we did not upgrade again until a5cac99 which never released, so hopefully it's not a big deal in the short term. 1.2.x will be losing support though, so we do have to move once the tests are sorted. |
picks up assorted updates ahead of v0.31.0